Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for node/48262 #30

Merged
merged 1 commit into from
May 31, 2023
Merged

test: add test for node/48262 #30

merged 1 commit into from
May 31, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented May 31, 2023

@anonrig anonrig requested a review from lemire May 31, 2023 19:34
@lemire
Copy link
Member

lemire commented May 31, 2023

Sure. But is that the issue with nodejs/node#48262 ?

@anonrig
Copy link
Member Author

anonrig commented May 31, 2023

Sure. But is that the issue with nodejs/node#48262 ?

I think the cause of this issue is something else. I just added these changes to align that this is indeed the correct value for this input.

@lemire
Copy link
Member

lemire commented May 31, 2023

Merging.

@lemire lemire merged commit 6c61430 into main May 31, 2023
@lemire lemire deleted the add-test-for-node branch May 31, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonrig @lemire