Adds code formatting check in the CI

[miguelteixeiraa]

ref: ada-url/ada#170 and ada-url/ada#243 (comment)
Hello There! @lemire @anonrig
How do we proceed with the format of the whole codebase? Is there any big (code)change currently in progress for this repo? If not, can we run the format for all files?

[anonrig]

I think you can format it in this pull request with an additional commit.

[anonrig]

Should we remove the existing hooks? It doesn't seem to be necessary anymore.

[miguelteixeiraa]

Should we remove the existing hooks? It doesn't seem to be necessary anymore.

Agreed!

[miguelteixeiraa]

I just crashed everything yayyyy 😅
I'll figure it out when I have a little more time

[anonrig]

I just crashed everything yayyyy 😅
I'll figure it out when I have a little more time

The order of imports in the header file broke it (which is a good thing because we did not include algorithms any other relevant libraries in the corresponding files)

[lemire]

If you reorder the include files, you may break the amalgamation. I recommend you do not reorder the include files.

[miguelteixeiraa]

If you reorder the include files, you may break the amalgamation. I recommend you do not reorder the include files.

Also, we would have problems with the includes order of idna.cpp, normalization.cpp, and probably more. Just added a SortIncludes: false to our .clang-format conf (probably have to also add it in ada)

[miguelteixeiraa]

If you reorder the include files, you may break the amalgamation. I recommend you do not reorder the include files.

Also, we would have problems with the includes order of idna.cpp, normalization.cpp, and probably more. Just added a SortIncludes: false to our .clang-format conf (probably have to also add it in ada)

Actually I think they are all about the amalgamation like @lemire said. I can try to refactor the amalgamation script + related things to not depend on the import order if the current solution is not okay

[lemire]

There are still issues even if you preserve the original include order?

[miguelteixeiraa]

There are still issues even if you preserve the original include order?

No issues when preserve the original includes order (don't know if it is in the original order now, but I can make it)

[lemire]

The exact order does not matter, but some orders will break the amalgamation script.

[anonrig]

It seems the ordering issue is resolved.

[miguelteixeiraa]

It seems the ordering issue is resolved.

That's correct.