Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement to_unicode #4

Closed
lemire opened this issue Feb 5, 2023 · 4 comments
Closed

Implement to_unicode #4

lemire opened this issue Feb 5, 2023 · 4 comments
Assignees
@miguelteixeiraa
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lemire
Copy link
Member

lemire commented Feb 5, 2023

It is just the reverse operation from to_ascii, seemingly without all the dense requirements.
@lemire lemire added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 5, 2023
@lemire
Copy link
Member Author

lemire commented Feb 5, 2023

@miguelteixeiraa This might be a doable task if you are interested.

@miguelteixeiraa
Copy link
Contributor

I'll pick up this one!

@lemire
Copy link
Member Author

lemire commented Feb 5, 2023

We don't have the tests for it yet, but if you look at
https://github.com/ada-url/idna/blob/main/tests/to_ascii_tests.cpp

You should figure out quickly how to do the reverse.

@lemire
Copy link
Member Author

lemire commented Feb 8, 2023

@miguelteixeiraa We now pass our own tests, so it should make your life easier.

@miguelteixeiraa miguelteixeiraa mentioned this issue Feb 11, 2023
Closed
@miguelteixeiraa miguelteixeiraa mentioned this issue Feb 19, 2023
Merged
lemire added a commit that referenced this issue Feb 25, 2023
@miguelteixeiraa @anonrig @lemire
To unicode #4 - clean PR (#17)
8cd03ef 
* src: reintroducing to_unicode

* src: adds algorithm lib

* fix: update tests/to_unicode_tests.cpp

Co-authored-by: Daniel Lemire <daniel@lemire.me>

* fix: update tests/to_unicode_tests.cpp

* src: refactoring to_unicode

* src: minor tweaks to to_unicode + add more tests

* src: add missing else statement in to_unicode.cpp

* src: use string_view::find instead of std::find in to_unicode.cpp

* src: use begins_with instead of find

---------

Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
Co-authored-by: Daniel Lemire <daniel@lemire.me>
@anonrig anonrig closed this as completed Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miguelteixeiraa miguelteixeiraa

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lemire @anonrig @miguelteixeiraa