improve performance one step at a time #734
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
perf-optimizations
branch
from
266c8a5
to
0e8c7db
Compare
lemire
reviewed
Sep 18, 2024
| @@ -188,7 +188,7 @@ inline void url::copy_scheme(const ada::url &u) { | |||
| if (has_credentials()) { | |||
| output += username; | |||
| if (!password.empty()) { | |||
| output += ":" + get_password(); | |||
| output += ":" + std::string(get_password()); | |||
There was a problem hiding this comment.
It was returning string& before now string view. I'll land these changes in a different PR to improve reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the functions can be
constexpras well as functions that use templates can directly check them usingif constexpr (param). I have some build issues, which I didn't had any time to look into it, but opening in case @lemire has some time.