fix issue 716 #717
Merged
fix issue 716 #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
Aug 22, 2024
bungle
approved these changes
Aug 22, 2024
|
It seems web-platform tests are failing with this change |
anonrig
reviewed
Aug 22, 2024
|
@anonrig My fix is not correct. |
|
@anonrig Annoyingly, it seems that we have to check for negative values separately. :-/ Latest commit should be correct. |
anonrig
approved these changes
Aug 22, 2024
| @@ -215,10 +215,15 @@ inline void url::copy_scheme(const ada::url &u) { | |||
| ada_really_inline size_t url::parse_port(std::string_view view, | |||
| bool check_trailing_content) noexcept { | |||
| ada_log("parse_port('", view, "') ", view.size()); | |||
| if (!view.empty() && view[0] == '-') { | |||
There was a problem hiding this comment.
Should we add ada_unlikely to here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #716