-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken stream when authentication failed #260
Conversation
Signed-off-by: Roland Ma <rolandma@outlook.com>
Signed-off-by: Roland Ma <rolandma@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible, +1
I don't see any relations between the commit and the failing doc tests. How do i to fix it? |
Due to rust-lang/rust#99261, let's ignore it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change seems fine, no better way to do it with the current middleware system so worth providing a solution instead of none
this is a neat way of solving the bug within the current constraints - thank you @RolandMa1986 |
PR Type
Bug Fix
PR Checklist
cargo +nightly fmt
).Overview
The handler's signature has been changed. I'm not sure whether it's acceptable. Please let me known it there's a better solution.