Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the Rails version to 7 #1205

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Bump the Rails version to 7 #1205

merged 1 commit into from
Feb 9, 2021

Conversation

yahonda
Copy link
Contributor

@yahonda yahonda commented Feb 8, 2021

This pull request addresses the LoadError: cannot load such file -- polyamorous/activerecord_7.0_ruby_2/join_association
reported at https://github.com/activerecord-hackery/ransack/runs/1835251570?check_suite_focus=true

Refer rails/rails@1b455e2
Fix #1204

deivid-rodriguez
deivid-rodriguez approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@scarroll32 scarroll32 merged commit ffc4e6c into activerecord-hackery:master Feb 9, 2021
@scarroll32
Copy link
Member

Many thanks @yahonda !

@yahonda yahonda mentioned this pull request Oct 20, 2021
Closed
@yahonda yahonda mentioned this pull request Apr 12, 2022
Merged
deivid-rodriguez pushed a commit that referenced this pull request Apr 12, 2022
@yahonda
Allow Ransack runs test against Rails main branch aka 7.1.0.alpha (#1309
b5e67ad 
)

Refer to #1192 and #1205 for the similar change to support 6.2.0.alpha
and 7.0.0.alpha

This commit should make cronjob CI green.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cronjob is failing
3 participants
@yahonda @scarroll32 @deivid-rodriguez