Don't pass data attribute appended to query params

activerecord-hackery · Apr 7, 2022 · a71ad58 · a71ad58
1 parent ce75337
commit a71ad58
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/ransack/helpers/form_helper.rb b/lib/ransack/helpers/form_helper.rb
@@ -130,7 +130,7 @@ def name
 
         def url_options
           @params.merge(
-            @options.except(:class).merge(
+            @options.except(:class, :data).merge(
               @search.context.search_key => search_and_sort_params))
         end
 

diff --git a/spec/ransack/helpers/form_helper_spec.rb b/spec/ransack/helpers/form_helper_spec.rb
@@ -758,6 +758,18 @@ module Helpers
         end
       end
 
+      describe '#sort_link with data option' do
+        subject { @controller.view_context
+          .sort_link(
+            [:main_app, Person.ransack(sorts: ['name desc'])],
+            :name,
+            data: { turbo_action: :advance }, controller: 'people'
+          )
+        }
+        it { should match /data-turbo-action="advance"/ }
+        it { should_not match /people\?data%5Bturbo_action%5D=advance/ }
+      end
+
       describe '#search_form_for with default format' do
         subject { @controller.view_context
           .search_form_for(Person.ransack) {} }