Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spaces in issues-processor.ts #748

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Conversation

Saibamen
Copy link
Contributor

@Saibamen Saibamen commented Jun 5, 2022

Changes

  • Fix spaces in issues-processor.ts

Context

image

@Saibamen Saibamen requested a review from a team as a code owner June 5, 2022 15:28
@luketomlinson
Copy link
Collaborator

@Saibamen You'll need to run npm run pack and commit the result too.

@Saibamen
Copy link
Contributor Author

Saibamen commented Jun 6, 2022

@Saibamen You'll need to run npm run pack and commit the result too.

@luketomlinson:

After npm install:

added 973 packages, and audited 974 packages in 28s

98 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

After npm run pack:

> stale-action@2.0.0 pack
> ncc build

Error: Cannot find module 'C:\Users\Adam\source\repos\stale\lib\main.js'. Please verify that the package.json has a valid "main" entry
    at tryPackage (node:internal/modules/cjs/loader:353:19)
    at Function.Module._findPath (node:internal/modules/cjs/loader:566:18)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:919:27)
    at resolve (node:internal/modules/cjs/helpers:108:19)
    at runCmd (C:\Users\Adam\source\repos\stale\node_modules\@vercel\ncc\dist\ncc/cli.js.cache.js:1:51752)
    at Object.819 (C:\Users\Adam\source\repos\stale\node_modules\@vercel\ncc\dist\ncc/cli.js.cache.js:1:48659)
    at __webpack_require__ (C:\Users\Adam\source\repos\stale\node_modules\@vercel\ncc\dist\ncc/cli.js.cache.js:1:55378)
    at C:\Users\Adam\source\repos\stale\node_modules\@vercel\ncc\dist\ncc/cli.js.cache.js:1:55590
    at C:\Users\Adam\source\repos\stale\node_modules\@vercel\ncc\dist\ncc/cli.js.cache.js:1:55651
    at Object.<anonymous> (C:\Users\Adam\source\repos\stale\node_modules\@vercel\ncc\dist\ncc\cli.js:8:28) {
  code: 'MODULE_NOT_FOUND',
  path: 'C:\\Users\\Adam\\source\\repos\\stale\\package.json',
  requestPath: 'C:\\Users\\Adam\\source\\repos\\stale'
}

NPM version: 8.10.0
Node version: v16.15.0

@luketomlinson
Copy link
Collaborator

@Saibamen does running nom run build first fix it? I forgot that needs to be run first 🤦‍♂️

@Saibamen
Copy link
Contributor Author

Saibamen commented Jun 6, 2022

@luketomlinson: fixed, thanks

@luketomlinson luketomlinson merged commit a78f180 into actions:main Jun 20, 2022
@Saibamen Saibamen deleted the patch-1 branch June 20, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants