-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operations-per-run appears to be ignored in 3.0.14 #230
Comments
Quick note, I used a secondary account when I posted this... for responses, it's best to @mention me at @william76 |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
bump |
I thought something similar but when I dove into the code a little bit it turned out that the operations per run just wasn't what I expected them to be Line 467 in 324009e
Where it uses up an operation every time it comes across an issue with the "stale" label |
@dwelch-r7 Ah, interesting. It'd be useful to know how I'm also pretty unfamiliar with Typescript -- if I wanted to fork this repository and poke around, is there something I'd need to to 'compile' the code so that I can point my YAML file to the version on my fork? I tried it once in a test repo and it didn't work, so my guess is there's some step that I'm unaware of? (A contributing guide for the app that explains how one might make mods and test them on their fork would be useful... 😉) |
Please see my comments in the PR but yes, the 'operations' parameter is used to track API calls for rate limiting. We can probably do a better job of calling that out in the docs, but it's not intended to be used as a "how many issues" count. |
Above PR should update the docs to be more clear. Will close this on merge. |
As far as I can tell, changing the
operations-per-run
does not change the behavior of the action script.I've tried varying it from 3 to 30 (the default) to 60 but in my test repository it always quits after looking at the same # of issues.
Documentation on what, exactly, this parameter does but my expectation is that it affects the number of issues it will process in a given run.
I'm testing this out in a test repository for possible deployment to clean up stale issues and PR's on a large project that I support that has around 100 developers. The project itself is decades old and has about 1100 open issues, some of which are years old.
I'd be happy to poke around with a fork of your script too but unfortunately I do not know Typescript. I tried a few things but it didn't appear to run with any of my edits on my fork. Is there a step I would need to take to compile the script so that I could point to a fork in my yaml script and have GitHub actions run it properly? Do you guys have any instructions on how to try out tweaks to the script? I didn't see a wiki or CONTRIBUTING.md documents.
The text was updated successfully, but these errors were encountered: