Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operations-per-run appears to be ignored in 3.0.14 #230

Closed
william76-bot opened this issue Nov 26, 2020 · 7 comments · Fixed by C0ZEN/stale#6
Closed

operations-per-run appears to be ignored in 3.0.14 #230

william76-bot opened this issue Nov 26, 2020 · 7 comments · Fixed by C0ZEN/stale#6
Labels
question Further information is requested

Comments

@william76-bot
Copy link

As far as I can tell, changing the operations-per-run does not change the behavior of the action script.

I've tried varying it from 3 to 30 (the default) to 60 but in my test repository it always quits after looking at the same # of issues.

Documentation on what, exactly, this parameter does but my expectation is that it affects the number of issues it will process in a given run.

I'm testing this out in a test repository for possible deployment to clean up stale issues and PR's on a large project that I support that has around 100 developers. The project itself is decades old and has about 1100 open issues, some of which are years old.

I'd be happy to poke around with a fork of your script too but unfortunately I do not know Typescript. I tried a few things but it didn't appear to run with any of my edits on my fork. Is there a step I would need to take to compile the script so that I could point to a fork in my yaml script and have GitHub actions run it properly? Do you guys have any instructions on how to try out tweaks to the script? I didn't see a wiki or CONTRIBUTING.md documents.

@william76
Copy link

Quick note, I used a secondary account when I posted this... for responses, it's best to @mention me at @william76

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Dec 29, 2020
@william76
Copy link

william76 commented Dec 29, 2020

bump

@github-actions github-actions bot removed the Stale label Dec 30, 2020
@dwelch-r7
Copy link

I thought something similar but when I dove into the code a little bit it turned out that the operations per run just wasn't what I expected them to be
I thought an operation would be marking an issue as stale or closing an issue, but the code seems to count several other things as an operation such as here:

this.operationsLeft -= 1;

Where it uses up an operation every time it comes across an issue with the "stale" label

@william76
Copy link

@dwelch-r7 Ah, interesting. It'd be useful to know how operations maps to the Github rate limiter.

I'm also pretty unfamiliar with Typescript -- if I wanted to fork this repository and poke around, is there something I'd need to to 'compile' the code so that I can point my YAML file to the version on my fork? I tried it once in a test repo and it didn't work, so my guess is there's some step that I'm unaware of?

(A contributing guide for the app that explains how one might make mods and test them on their fork would be useful... 😉)

@hross
Copy link
Contributor

hross commented Jan 15, 2021

Please see my comments in the PR but yes, the 'operations' parameter is used to track API calls for rate limiting. We can probably do a better job of calling that out in the docs, but it's not intended to be used as a "how many issues" count.

@hross hross added the question Further information is requested label Jan 15, 2021
@hross hross changed the title [Bug] operations-per-run appears to be ignored in 3.0.14 operations-per-run appears to be ignored in 3.0.14 Jan 15, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this issue Jan 16, 2021
@hross
Copy link
Contributor

hross commented Jan 17, 2021

Above PR should update the docs to be more clear. Will close this on merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants