Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Oracle GraalVM #501

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Add support for Oracle GraalVM #501

merged 2 commits into from
Sep 18, 2024
+550 −5

Conversation

fniephaus
Copy link
Contributor

Description:
This PR adds Oracle GraalVM JDK to the list of supported distributions.

Related issue: #401

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@fniephaus fniephaus requested a review from a team as a code owner June 20, 2023 06:54
@fniephaus fniephaus force-pushed the fniephaus/graalvm branch 2 times, most recently from bbee66a to 2ba39e0 Compare June 20, 2023 07:02
@fniephaus fniephaus mentioned this pull request Jun 20, 2023
Closed
@IvanZosimov IvanZosimov mentioned this pull request Jul 3, 2023
Closed
@IvanZosimov IvanZosimov linked an issue Jul 3, 2023 that may be closed by this pull request
Add support for the Oracle GraalVM JDK #504
Closed
stevenschlansker
stevenschlansker approved these changes Aug 21, 2023
View reviewed changes
Copy link

@stevenschlansker stevenschlansker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are looking for the ability to test with Workflows against GraalVM as well!

tisonkun
tisonkun approved these changes Sep 20, 2023
View reviewed changes
Copy link

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Out thread - Does this action support OpenJDK?

@fniephaus
Copy link
Contributor Author

Any update on this?

@wetneb
Copy link

wetneb commented Sep 25, 2023

@IvanZosimov if you could find time to merge this, it would be really amazing! Thank you for your work.

@Yaytay
Copy link

Yaytay commented Oct 6, 2023

Ideally this should support the new release and approach to naming from GraalVM.

@fniephaus
Copy link
Contributor Author

@IvanZosimov and @dmitry-shibanov, do you have an update on this? There's now a merge conflict that needs to be resolved but I don't want to do this work if a review and approval still take time.

@fniephaus
Copy link
Contributor Author

I'm assuming this is still pending licensing approval, @IvanZosimov? Please let me know if there's anything we can help with.

@fniephaus
Copy link
Contributor Author

Maybe @brunoborges could help move this forward?

@fniephaus fniephaus mentioned this pull request May 7, 2024
Merged
2 tasks
@fniephaus
Copy link
Contributor Author

Is there any update on this? It's been over a year now and it'd be nice if we can move this forward.

@fniephaus
Copy link
Contributor Author

@aparnajyothi-y I see that SapMachine support is planned for Q4. Can we please proceed with this and add Oracle GraalVM support, too?

@aparnajyothi-y
Copy link
Contributor

Hello @fniephaus, We are working to prioritize this feature. We will update you once we have some feedback :)

@fniephaus
Copy link
Contributor Author

Thanks, @aparnajyothi-y. Let me know when this is planned so I can help resolve the merge conflicts. :)

@SandraAhlgrimm
Copy link

Hi @aparnajyothi-y, any updates here?

@HarithaVattikuti
Copy link
Contributor

Hello Everyone, we are in the process of reviewing this PR.
Feedback will be provided once the review is complete.

@fniephaus
Copy link
Contributor Author

Feedback will be provided once the review is complete.

Thanks! Let me know and we can work on resolving merge conflicts.

@mahabaleshwars
Copy link
Contributor

Hi @fniephaus, could you please resolve the conflicts so we can proceed with testing and approving the PR?

@fniephaus fniephaus force-pushed the fniephaus/graalvm branch 2 times, most recently from f486d37 to 728f3df Compare September 5, 2024 07:21
@fniephaus fniephaus changed the title Add support for Oracle GraalVM JDK Add support for Oracle GraalVM Sep 5, 2024
@fniephaus fniephaus force-pushed the fniephaus/graalvm branch 3 times, most recently from c02f2a2 to d8356f8 Compare September 5, 2024 08:36
@fniephaus
Copy link
Contributor Author

Hi @mahabaleshwars,
I have resolved the merge conflicts and have added support for GraalVM EA builds. Please test and review the PR and let me know if anything needs changing.

@fniephaus
Copy link
Contributor Author

I see there are new merge conflicts. When will this PR be merged? I wouldn't want to keep resolving merge conflicts.

@fniephaus
Copy link
Contributor Author

I have resolved the merge conflicts again. It'd be great if this could be merged soon, thanks!

@fniephaus
Copy link
Contributor Author

All tests are passing and there are plenty of approvals. When will this be merged? :)

@HarithaVattikuti HarithaVattikuti merged commit 0a40ce6 into actions:main Sep 18, 2024
334 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenschlansker stevenschlansker stevenschlansker approved these changes

@alina-yur alina-yur alina-yur approved these changes

@tisonkun tisonkun tisonkun approved these changes

@HarithaVattikuti HarithaVattikuti HarithaVattikuti approved these changes

@aparnajyothi-y aparnajyothi-y aparnajyothi-y approved these changes

@priya-kinthali priya-kinthali priya-kinthali approved these changes

@mahabaleshwars mahabaleshwars mahabaleshwars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the Oracle GraalVM JDK