Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[versions-manifest] Update for release from 07/19/2024 #182

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[versions-manifest] Update for release from 07/19/2024 #182

merged 1 commit into from
Jul 22, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Update versions-manifest.json for release from 07/19/2024

@github-actions github-actions bot requested a review from a team as a code owner July 19, 2024 15:49
@danielhjacobs danielhjacobs mentioned this pull request Jul 19, 2024
Closed
5 tasks
@Trott Trott mentioned this pull request Jul 19, 2024
Merged
@Sebastian-Webster Sebastian-Webster mentioned this pull request Jul 19, 2024
Closed
2 tasks
@MikeMcC399
Copy link

MikeMcC399 commented Jul 19, 2024 •
edited
Loading

Any workflow specifying node-version: 22 in actions/setup-node currently fails in GitHub Actions with

npm error Exit handler never called!

@danielhjacobs danielhjacobs mentioned this pull request Jul 19, 2024
Merged
zachleat added a commit to 11ty/eleventy that referenced this pull request Jul 19, 2024
@zachleat
Removing Node 22 via actions/node-versions#182
f70f17b
@romainmenke romainmenke mentioned this pull request Jul 19, 2024
Closed
@torokati44 torokati44 mentioned this pull request Jul 19, 2024
Merged
@MikeMcC399 MikeMcC399 mentioned this pull request Jul 20, 2024
Merged
1 task
@hoeck hoeck mentioned this pull request Jul 20, 2024
Merged
@jsumners
Copy link

I appreciate that the action is pulling from your own infrastructure so as not to blow up someone else's, but this whole process really needs to be more automated and immediate. Why does this need to wait on a human to intervene? Why wasn't this manifest update part of the PR that added 22.5.1 to the releases list? When are we going to be able to run our CI jobs that utilize 22.x again?

@RobinTail
Copy link

@HarithaVattikuti || @aparnajyothi-y || @priya-kinthali || @priyagupta108, please merge

This was referenced Jul 21, 2024
Merged
Merged
@jeswr jeswr mentioned this pull request Jul 21, 2024
Merged
@LitoMore LitoMore mentioned this pull request Jul 21, 2024
Closed
Elanis added a commit to Dysnomia-Studio/dysnomia-wiki that referenced this pull request Jul 21, 2024
@Elanis
Pin node version to 22.4
752a9a1 
Awaiting for actions/node-versions#182 because of npm/cli#7667
@julienp julienp mentioned this pull request Jul 21, 2024
Merged
RobinTail
RobinTail approved these changes Jul 21, 2024
View reviewed changes
Copy link

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I heard if it's approved 255 times then it will be merged automatically without involving code owners :)

@LitoMore
Copy link

LitoMore commented Jul 21, 2024 •
edited
Loading

I heard if it's approved 255 times then it will be merged automatically without involving code owners :)

@RobinTail Please do not spread false information.

@torokati44
Copy link

Can't hurt to try... 🙄

@Standard8
Copy link

Standard8 commented Jul 21, 2024 •
edited
Loading

Please do not, it unnecessary spams everyone that is following this issue, wasting everyone's time. Please refrain from commenting, and be patient until a one of the maintainers are available.

@aladdin-add aladdin-add mentioned this pull request Jul 22, 2024
Merged
@RobinTail
Copy link

What is that thing that's currently keeping you from merging it, @priya-kinthali && @priyagupta108 && @aparnajyothi-y ?

@HarithaVattikuti HarithaVattikuti merged commit c749aff into main Jul 22, 2024
@fisker fisker mentioned this pull request Jul 22, 2024
Merged
4 tasks
This was referenced Jul 22, 2024
Closed
Merged
@jsumners-nr jsumners-nr mentioned this pull request Jul 22, 2024
Merged
@Sebastian-Webster Sebastian-Webster mentioned this pull request Jul 24, 2024
Merged
7 tasks
zachleat added a commit to 11ty/eleventy that referenced this pull request Jul 29, 2024
@zachleat
Restore Node 22 actions/node-versions#182
ed84827
@zachleat zachleat mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torokati44 torokati44 torokati44 approved these changes

@LitoMore LitoMore LitoMore approved these changes

@RobinTail RobinTail RobinTail approved these changes

@aparnajyothi-y aparnajyothi-y aparnajyothi-y approved these changes

@priya-kinthali priya-kinthali priya-kinthali approved these changes

@priyagupta108 priyagupta108 priyagupta108 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.