fix ci by updating node 22x version to 22.5.1 #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kanthesha we should update github workflow here https://github.com/MetaMask/eth-token-tracker/blob/main/.github/workflows/build-lint-test.yml (all node-version) we don't need to update package.json ? what do you think ? |
|
The solution has been tested in the forked repo and it works fine. Here is the link. |
|
Seems like we don't need a fix now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a regression in Node 22.5.0 which yarnpkg/berry#6398 and in turns prevents CI from completing successfully. This regression was nodejs/node#53935. We are using 22.x in CI, so in theory it should be using this version, but that does not seem be the case right now. So this commit ensures that CI is using this version by naming it explicitly in engines.node of package.json.