-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose dependency comment content #695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsoref thanks for this, it looks helpful, and code-wise I think we're good.
Before merging: can you add an example of how this would be used in https://github.com/actions/dependency-review-action/blob/main/docs/examples.md?
|
||
or on the job summary: | ||
|
||
<img src="https://user-images.githubusercontent.com/7847935/182871416-50332bbb-b279-4621-a136-ca72a4314301.png"> | ||
<img alt="GitHub job summary showing Dependency Review output" src="https://user-images.githubusercontent.com/7847935/182871416-50332bbb-b279-4621-a136-ca72a4314301.png"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the picture here is really out of date, it includes a typo that was fixed in 2022: dfcdb87
@@ -164,6 +164,37 @@ jobs: | |||
comment-summary-in-pr: always | |||
``` | |||
|
|||
## Getting the results of the action in a later step | |||
|
|||
Using the `comment-content` output you can get the results of the action in a workflow step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This precise workflow is untested.
The workflow I used is here:
https://github.com/check-spelling-sandbox/dependency-review-action-0/blob/657ea37667b5afdb8c94c4197272ba19adbfa0af/.github/workflows/dependency-review.yml
I believe they're functionally equivalent, but someone should really carefully review (or better, test).
GHES 3.6 reached EOL 2023-09-25.
GHES 3.7 reached EOL 2024-01-04, as such all GHES versions should be supported.
The docs server will redirect based on the user's browser's preference.
Hmm... I wonder if I have a pref set to block that. I thought I usually allowed them... |
Closes #250