Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for arm64 too #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sjchmiela
Copy link

We can build for ARM64 similarly to how we build for x64, just need to pass the architecture info here and there.

Helps fix https://github.com/orgs/community/discussions/53407 and actions/runner#801. (Doesn't actually fix, because changes will also be required in the Actions Worker, but this is a good start.)

There are two to-dos:

  1. Set up an ARM64 runner for testing the ARM64 binary (comment left in matrix).
  2. Ensure uploading multiple artifacts like this works (not sure, also this is an outdated upload-artifact action).

I have build Node manually on my computer like this (M1 on ARM alpine). It worked!

@sjchmiela sjchmiela requested a review from a team as a code owner June 21, 2024 20:47
@joeyparrish
Copy link

@actions/actions-runtime, please consider this. We need arm64 support on Alpine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants