macrecovery: Fix ValueError #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `os.get_terminal_size().columns` is less than 2 then the align left padding has a negative value, giving the error `ValueError: Sign not allowed in string format specifier`.
|
Thank you for pointing out the issue when running headless. Can you confirm that it works fine for you with my suggested additional commit? |
|
Yes, I can confirm that it works fine for me with your commit. Thank you for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the script in a builder, I was getting the error that
Image verification failed. (Sign not allowed in string format specifier). Ifos.get_terminal_size().columnsis less than 2 then the align left padding has a negative value, giving the errorValueError: Sign not allowed in string format specifier. I just added a check before the value's use to ensure that it isn't negative.