Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow user to change password without MFA configured #19

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

jufemaiz
Copy link
Member

@jufemaiz jufemaiz commented Jan 7, 2024

Where a user does not have a PGP and an administrator resets the password via API/console requiring a change of password upon first authentication (enforcing unknown password beyond the user), GetLoginProfile and UpdateLoginProfile is needed.

@jufemaiz jufemaiz requested a review from sjauld January 7, 2024 23:56
@sjauld
Copy link
Collaborator

sjauld commented Jan 8, 2024

Why?

@jufemaiz
Copy link
Member Author

jufemaiz commented Jan 8, 2024

Why?

See above.

@sjauld
Copy link
Collaborator

sjauld commented Jan 8, 2024

Oh.

@jufemaiz
Copy link
Member Author

jufemaiz commented Jan 8, 2024

Also, the boffins at aws thought it a good idea to let users name their MFA resources whatever they like. 🤦🏼

@jufemaiz
Copy link
Member Author

jufemaiz commented Jan 8, 2024

Approved @sjauld?

Copy link
Collaborator

@sjauld sjauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.... But I didn't know you were still using this! I'll see what changes I need to add.

@jufemaiz jufemaiz merged commit 551ea7b into master Jan 8, 2024
@jufemaiz jufemaiz deleted the fix/can-get-login-profile-without-iam branch January 8, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants