Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puppet::profile::puppetboard: Add feature for enabling/disabling SSL #172

Open
wants to merge 2 commits into
base: production
Choose a base branch
from
Open

puppet::profile::puppetboard: Add feature for enabling/disabling SSL #172

wants to merge 2 commits into from

Conversation

clement-parisot
Copy link

@clement-parisot clement-parisot commented Feb 19, 2019 •
edited
Loading

Hello,
I have just added SSL support to puppetboard. I have kept backward compatibility. It uses ::puppetboard::apache::vhost ssl, ssl_key and ssl_cert options.

puppet::profile::puppetboard: Add feature for enabling/disabling SSL
473d3a4 
Signed-off-by: Clement Parisot <clement.parisot@uni.lu>
hcartiaux
hcartiaux approved these changes Apr 6, 2020
View reviewed changes
Copy link

@hcartiaux hcartiaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are used in production for while on our side.
It's safe and does not change the default behavior.

@Falkor
Copy link

Falkor commented Apr 6, 2021

Updated to 2.4.1.
Would be great if you could merge that PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcartiaux hcartiaux hcartiaux approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clement-parisot @Falkor @hcartiaux