Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Contributors #453

Closed
5 tasks done
Brittank88 opened this issue Feb 2, 2022 · 34 comments
Closed
5 tasks done

Adding Contributors #453

Brittank88 opened this issue Feb 2, 2022 · 34 comments
Assignees
Labels
repo / tracker Issues related to the repo or issue tracker themselves

Comments

@Brittank88
Copy link
Collaborator

Brittank88 commented Feb 2, 2022

This is where I'll perform my testing whilst I get All-Contributors to work correctly.

Need to add the following people:

  • Absolute
  • Brittank88 (me!!!)
  • MainConMan
  • Nicko2102
  • Zohnannor
@Brittank88 Brittank88 added the repo / tracker Issues related to the repo or issue tracker themselves label Feb 2, 2022
@Brittank88 Brittank88 self-assigned this Feb 2, 2022
@Brittank88
Copy link
Collaborator Author

@all-contributors please add @absoIute for bug, business, code, content, doc, design, financial, fundingFinding, ideas, infra, maintenance, projectManagement, question and security.

@allcontributors
Copy link
Contributor

@Brittank88

I've put up a pull request to add @absoIute! 🎉

@Brittank88
Copy link
Collaborator Author

It keeps making PRs where it doesn't even add to the file...

@zohnannor
Copy link

zohnannor commented Feb 3, 2022

It keeps making PRs where it doesn't even add to the file...

Hm. Just before you closed it's PR, a new repo branch appeared that had changes to .all-contributorsrc file. I wonder why merging the PRs #451 & #452 didn't update the file despite it having the changes🤔

Edit: Oh, sorry. It needs to update CONTRIBUTORS.md file using the generated "template", I missed this commit of yours removing the changes c2ad03a. Now I get it

@Brittank88
Copy link
Collaborator Author

Brittank88 commented Feb 3, 2022

It keeps making PRs where it doesn't even add to the file...

Hm. Just before you closed it's PR, a new repo branch appeared that had changes to .all-contributorsrc file. I wonder why merging the PRs #451 & #452 didn't update the file despite it having the changes🤔

It has to create a new branch in order to request a PR between that branch and main. It's just the standard process - it adds contributor entries to .all-contributorssrc each time, like an internal listing.

Also I had to revert the change to README.md because it simply broke the file lol.

@Brittank88
Copy link
Collaborator Author

@all-contributors please add @absoIute for bug, business, code, content, doc, design, financial, fundingFinding, ideas, infra, maintenance, projectManagement, question and security.

@allcontributors
Copy link
Contributor

@Brittank88

File CONTRIBUTORS.md was not found in the repository (absoIute/Mega-Hack-Pro-Future).

@Brittank88
Copy link
Collaborator Author

..So it needs to exist but when it exists it doesn't even add anything. Okay then...

I'll try creating the file with some existing structure there for it to update?

@Brittank88
Copy link
Collaborator Author

@all-contributors please add @Brittank88 for bug, content, doc, ideas, maintenance, mentoring, projectManagement and question.

@allcontributors
Copy link
Contributor

@Brittank88

I've put up a pull request to add @Brittank88! 🎉

@Brittank88
Copy link
Collaborator Author

Okay I've got it now!!!

@Brittank88
Copy link
Collaborator Author

@all-contributors please add @absoIute for bug, business, code, content, doc, design, financial, fundingFinding, ideas, infra, maintenance, projectManagement, question and security.

@allcontributors
Copy link
Contributor

@Brittank88

I've put up a pull request to add @absoIute! 🎉

@Brittank88
Copy link
Collaborator Author

@all-contributors please add @Brittank88 for bug, content, doc, ideas, maintenance, mentoring, projectManagement and question.

@allcontributors
Copy link
Contributor

@Brittank88

I've put up a pull request to add @Brittank88! 🎉

@Brittank88
Copy link
Collaborator Author

@all-contributors please add @absoIute for review

@allcontributors
Copy link
Contributor

@Brittank88

I've put up a pull request to add @absoIute! 🎉

@Brittank88
Copy link
Collaborator Author

@all-contributors please add @Brittank88 for review

@allcontributors
Copy link
Contributor

@Brittank88

I've put up a pull request to add @Brittank88! 🎉

@Brittank88
Copy link
Collaborator Author

Okay so finally at least us two should be sorted.

@Brittank88
Copy link
Collaborator Author

@all-contributors please add @zohnannor, @Nicko2102, @MainConMan for bug, ideas, maintenance, question.

@allcontributors
Copy link
Contributor

@Brittank88

Could not find the user zohnannor, on github.

@Brittank88
Copy link
Collaborator Author

Darn, was hoping that would work.

@Brittank88
Copy link
Collaborator Author

@all-contributors please add @zohnannor and @Nicko2102 and @MainConMan for bug, ideas, maintenance and question.

@allcontributors
Copy link
Contributor

@Brittank88

I've put up a pull request to add @zohnannor! 🎉

@Brittank88
Copy link
Collaborator Author

Don't worry about the other two I guess LMAO

@Brittank88
Copy link
Collaborator Author

@all-contributors please add @Nicko2102 for bug, ideas, maintenance and question.
@all-contributors please add @MainConMan for bug, ideas, maintenance and question.

@allcontributors
Copy link
Contributor

@Brittank88

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@Brittank88
Copy link
Collaborator Author

@all-contributors please add @Nicko2102 for bug, ideas, maintenance and question.

@allcontributors
Copy link
Contributor

@Brittank88

I've put up a pull request to add @Nicko2102! 🎉

@Brittank88
Copy link
Collaborator Author

@all-contributors please add @MainConMan for bug, ideas, maintenance and question.

@allcontributors
Copy link
Contributor

@Brittank88

I've put up a pull request to add @MainConMan! 🎉

@zohnannor
Copy link

Don't worry about the other two I guess LMAO

"The bot will use basic Natural Language Parsing to determine your intent.", they say😄

@Brittank88
Copy link
Collaborator Author

Don't worry about the other two I guess LMAO

"The bot will use basic Natural Language Parsing to determine your intent.", they say😄

To be fair, they're working on it: all-contributors/app#127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo / tracker Issues related to the repo or issue tracker themselves
Projects
None yet
Development

No branches or pull requests

2 participants