Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several small fixes and improvements #48

Merged
merged 23 commits into from
Jan 6, 2020

Conversation

berendkleinhaneveld
Copy link
Contributor

Thanks for making this tool! Comes in really handy!
While using it, I stumbled on some small issues, so here is a pull request which should fix those.

  • Replaced a deprecated Qt method with a newer
  • Added shortcuts for
    • opening image folder (Ctrl+O)
    • opening configuration file (Ctrl+Shift+O)
  • Fixed shortcuts for labels not working after loading other configuration file
  • Changed the shortcuts of labels to be even easier (less modifier keys)
  • Refactor whitespace and coding style here and there (sorry, can't help it while I'm reading code ;) )

@berendkleinhaneveld
Copy link
Contributor Author

I'm currently fixing the Appveyor CI. Seems that the latest version of curl is a bit too sensitive (curl/curl#4624). For now I'm trying out an earlier version.

@berendkleinhaneveld
Copy link
Contributor Author

CI is passing again!

@abreheret abreheret merged commit 36aee06 into abreheret:master Jan 6, 2020
@abreheret
Copy link
Owner

Thank you for your contribution, I will release if you have no other features to add ?

@berendkleinhaneveld
Copy link
Contributor Author

There are two things that I would like to add in another PR: 'Save all masks' and keyboard shortcuts to select the next/previous file in the folder, but don't let me stop you from releasing another version. I'm ok either way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants