Merge pull request #21 from ubermanu/feat/keep-knockout-comments

feat: keep knockout comments
abordage · Feb 28, 2024 · 8b9bd09 · 8b9bd09
2 parents 2e2d9a3 + a96c131
commit 8b9bd09
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/HtmlMin.php b/src/HtmlMin.php
@@ -67,7 +67,7 @@ protected function doctypeNotFound(string $html): bool
 
     protected function removeHtmlComments(string $html): string
     {
-        return (string)preg_replace('~<!--[^]><!\[](?!Livewire)(.*?)[^]]-->~s', '', $html);
+        return (string)preg_replace('~<!--[^]><!\[](?!Livewire|ko |/ko)(.*?)[^]]-->~s', '', $html);
     }
 
     protected function trimScriptElements(string $html): string

diff --git a/tests/HtmlMinTest.php b/tests/HtmlMinTest.php
@@ -94,6 +94,20 @@ public function testLivewire(): void
         $this->assertEquals($expected, $this->htmlMin->minify($html));
     }
 
+    public function testKnockout(): void
+    {
+        $html = "<div>
+        <!-- ko if: true -->
+            <span>First item</span>
+        <!-- /ko -->
+
+        <!-- ko template: getTemplate() --><!-- /ko -->
+
+        </div>";
+        $expected = "<div><!-- ko if: true --><span>First item</span><!-- /ko --><!-- ko template: getTemplate() --><!-- /ko --></div>";
+        $this->assertEquals($expected, $this->htmlMin->minify($html));
+    }
+
     public function testStyleTag(): void
     {
         $html = "<style>