Skip to content

Commit

Permalink
Fix the typing_extensions runtime dependency version (#641)
Browse files Browse the repository at this point in the history
* Only use `typing_extensions` below Python 3.8

* Rely on unconstrained `typing-extensions` version
  • Loading branch information
webknjaz authored Oct 31, 2021
1 parent 03ed5d4 commit cb24389
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
9 changes: 8 additions & 1 deletion proxy/common/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,17 @@
"""
import queue
import ipaddress
import sys

from typing import TYPE_CHECKING, Dict, Any, List, Union

from typing_extensions import Protocol
# NOTE: Using try/except causes linting problems which is why it's necessary
# NOTE: to use this mypy/pylint idiom for py36-py38 compatibility
# Ref: https://github.com/python/typeshed/issues/3500#issuecomment-560958608
if sys.version_info >= (3, 8):
from typing import Protocol
else:
from typing_extensions import Protocol

if TYPE_CHECKING:
DictQueueType = queue.Queue[Dict[str, Any]] # pragma: no cover
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
typing-extensions==3.10.0.2
typing-extensions==3.10.0.2; python_version < "3.8"
4 changes: 3 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
zip_safe=False,
packages=find_packages(exclude=['tests', 'tests.*']),
package_data={'proxy': ['py.typed']},
install_requires=open('requirements.txt', 'r').read().strip().split(),
install_requires=[
'typing-extensions; python_version < "3.8"',
],
entry_points={
'console_scripts': [
'proxy = proxy:entry_point'
Expand Down

0 comments on commit cb24389

Please sign in to comment.