Skip to content

Commit

Permalink
Fix publishing a GitHub Release from GHA (#811)
Browse files Browse the repository at this point in the history
  • Loading branch information
webknjaz authored Nov 26, 2021
1 parent e5e900f commit 40a6f50
Showing 1 changed file with 20 additions and 7 deletions.
27 changes: 20 additions & 7 deletions .github/workflows/test-library.yml
Original file line number Diff line number Diff line change
Expand Up @@ -802,6 +802,7 @@ jobs:

permissions:
contents: write
discussions: write

steps:
- name: Download all the dists
Expand All @@ -813,15 +814,27 @@ jobs:
- name: >-
Publish a GitHub Release for
${{ needs.pre-setup.outputs.git-tag }}
uses: softprops/action-gh-release@v1
uses: ncipollo/release-action@v1.8.10
with:
# body/body_path: # FIXME: Use once Towncrier is integrated.
discussion_category_name: Announcements
fail_on_unmatched_files: true
files: |
allowUpdates: false
artifactErrorsFailBuild: false
artifacts: |
dist/${{ needs.pre-setup.outputs.sdist-artifact-name }}
dist/${{ needs.pre-setup.outputs.wheel-artifact-name }}
artifactContentType: raw # Because whl and tgz are of different types
# body/bodyFile: # FIXME: Use once Towncrier is integrated.
commit: ${{ github.event.inputs.release-commitish }}
discussionCategory: Announcements
draft: false
name: ${{ needs.pre-setup.outputs.git-tag }}
tag_name: ${{ needs.pre-setup.outputs.git-tag }}
target_commitish: ${{ github.event.inputs.release-commitish }}
# omitBody: false
omitBodyDuringUpdate: true
omitName: false
omitNameDuringUpdate: true
omitPrereleaseDuringUpdate: true
prerelease: false
removeArtifacts: false
replacesArtifacts: false
tag: ${{ needs.pre-setup.outputs.git-tag }}
token: ${{ secrets.GITHUB_TOKEN }}
...

0 comments on commit 40a6f50

Please sign in to comment.