Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Events example misleading #141

Closed
UncleDave opened this issue Oct 6, 2017 · 0 comments
Closed

Docs: Events example misleading #141

UncleDave opened this issue Oct 6, 2017 · 0 comments
Assignees
@UncleDave
Labels
task

Comments

@UncleDave
Copy link
Collaborator

"Events" html example shows (uploadFinished)="onUploadFinished($event)", however in the Typescript snippet this method does not exist, and imageFinishedUploading(file: FileHolder) is shown instead.

Change the typescript method to be onUploadFinished.
@UncleDave UncleDave added the task label Oct 6, 2017
@UncleDave UncleDave self-assigned this Oct 6, 2017
aberezkin added a commit that referenced this issue Apr 16, 2018
@aberezkin
1.0.0-rc.1 (#197)
9f104fd 
* fix: fixed FileHolder.serverResponse not being set correctly
chore: removed some type definitions that could be trivially inferred

fixes #142

* chore(docs): made events example a bit clearer
chore(docs): added a bit more content to root readme

fixes #141

* fix: hide upload button when reaches to max images (#145) (#147)

* feat(input): interface for disabling clear and upload (#148)

* Implement disable interface

* Add demo of disabled component

* Update docs

* fix: Parameter 'UploadMetadata' implicitly has an 'any' type. #154 (#155)

fixes #154

* fix: url changed by onBeforeUpload is ignored (#182)

* feat: added previewClicked output property (#188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UncleDave UncleDave

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@UncleDave