-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Puppeteer and other dependencies #21
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/axe-core@4.8.4), npm/c8@9.1.0), npm/commander@12.0.0), npm/envinfo@7.11.1), npm/eslint-plugin-mocha@10.4.1), npm/mocha@10.3.0), npm/puppeteer@22.3.0), npm/semver@7.6.0), npm/sinon@17.0.1) |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again. Next stepsWhat is eval?Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior. Avoid packages that use eval, since this could potentially execute any code. What is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. What is environment variable access?Package accesses environment variables, which may be a sign of credential stuffing or data theft. Packages should be clear about which environment variables they access, and care should be taken to ensure they only access environment variables they claim to. What is shell access?This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code. Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced. What is filesystem access?Accesses the file system, and could potentially read sensitive data. If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead. What is dynamic require?Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution. Packages should avoid dynamic imports when possible. Audit the use of dynamic require to ensure it is not executing malicious or vulnerable code. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
91626da
to
0e70672
Compare
f61bd03
to
bf52e00
Compare
This PR updates all dependencies to the latest supported, applicable versions (unless otherwise noted). One of these had breaking changes, as noted. It also adds test for Node 22 and updates the lint action to Node 20 as the Active LTS release.
Dependencies:
puppeteer
from 22.3.0 to 23.2.1, which updates from Chrome 126 to 128axe-core
from 4.8.4 to 4.10.0. Updated integration test based on new findings. The following issue was removed as a false positive by fix(region): Decorative images ignored by region rule dequelabs/axe-core#4412, which considers<img alt="">
to be not visible to screen readers and therefore decorative.commander
from 12.0.0 to 12.1.0envinfo
from 7.11.1 to 7.13.0semver
from 7.6.0 to 7.6.3Dev Dependencies:
sinon
from 17.0.1 to 18.0.0c8
from 9.1.0 to 10.1.2mocha
from 10.3.0 to 10.7.3eslint-plugin-mocha
from 10.4.1 to 10.5.0Actions
Not Updated
eslint
to v9 since it should include updatingpa11y-lint-config
to flat config since the legacy config format is now deprecated.