refactor(client): use cobra's builtin completion emitter #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cobra v1.2.0+ contains a default completion emitter, we could make use of it.
However, the default emitter outputs cobra's "V2" completions, which are a lot slower than the traditional ones, see spf13/cobra#1680. This is relevant for example with hostname completions which may return a lot of entries.
In that sense I actually don't recommend merging this yet, until there's some way to address the slowness. So marking as a draft.