Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ clean up result.text() #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

doron2402
Copy link

Description:

  • using .json() instead of using JSON.parse

@doron2402
Copy link
Author

hey @a-tokyo let me know if there's anything I can add to this PR

Copy link
Owner

@a-tokyo a-tokyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work!

Thanks for your patience, I haven't seen the notifs for this

@@ -0,0 +1 @@
v16.17.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file please

@a-tokyo a-tokyo changed the title cleaning up result.text() since we always parsing to json ⚡️ cleaning up result.text() since we always parsing to json Dec 22, 2022
@a-tokyo a-tokyo changed the title ⚡️ cleaning up result.text() since we always parsing to json ⚡️ clean up result.text() Dec 22, 2022
@a-tokyo
Copy link
Owner

a-tokyo commented Dec 22, 2022

Sidenote: I believe this code was added to handle an edge case, I will trace back and check the reason for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants