Several ImageMagick related bug fixes #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzz option "does nothing" to output file due to wrong order of params passsed to ImageMagick, these changes fix this issue.
write_gif() ImageMagick fix
Fixes Zulko#113 Fixes bug when exporting to gif using ImageMagick with no "opt" parameter specified ie `opt=OptimizePlus` does not produce output file while still stating that [MoviePy] >>>> File /.../test.gif is ready! test snippet: ` from moviepy.editor import * clip = (VideoFileClip(infile, audio=False)) clip.write_gif('test.gif', program= 'ImageMagick', fuzz=40) `
write_gif() using ImageMagick bugfix
|
This looks good to me. Let us know if there are any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for ImageMagick write gif success but no file found #113
Fix for another bug when setting fuzz had no influence on output file due to wrong order of params passsed to ImageMagick