Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fullscreen parameter to preview() #773

Merged
merged 3 commits into from
Apr 22, 2018
Merged

Added fullscreen parameter to preview() #773

merged 3 commits into from
Apr 22, 2018

Conversation

tburrows13
Copy link
Collaborator

@tburrows13 tburrows13 commented Apr 21, 2018 •
edited
Loading

@coveralls
Copy link

coveralls commented Apr 21, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 65.417% when pulling 4538fb6 on tburrows13:previewfullscreen into 497c852 on Zulko:master.

Repository owner deleted a comment from coveralls Apr 21, 2018
Repository owner deleted a comment from coveralls Apr 21, 2018
Repository owner deleted a comment from coveralls Apr 21, 2018
@tburrows13 tburrows13 merged commit b0f09c7 into Zulko:master Apr 22, 2018
@tburrows13 tburrows13 deleted the previewfullscreen branch April 22, 2018 17:46
@tburrows13
Copy link
Collaborator Author

Note to self: might want to look into automatically resizing videos so that they are under the total screen resolution, else it might crash.

@tburrows13 tburrows13 added the feature New addition to the API i.e. a new class, method or parameter. label Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New addition to the API i.e. a new class, method or parameter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tburrows13 @coveralls