Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoClip.write_videofile() accepts new param: ffmpeg_params that is put directly into ffmpeg command line #77

Merged
merged 2 commits into from
Oct 10, 2014

Conversation

aherok
Copy link

@aherok aherok commented Oct 9, 2014

Additional ffmpeg parameters are now available when saving video file.

@Zulko Zulko merged commit 70892d9 into Zulko:master Oct 10, 2014
@Zulko
Copy link
Owner

Zulko commented Oct 10, 2014

Warning ! It's merged but with namy other changes in the code (nothing important on the user side)

@aherok
Copy link
Author

aherok commented Oct 10, 2014

True - there are many non-important changes, I was just reformatting the code before changing more - visible in commit history. It's still not pep8 compliant, but at least has 4-spaced indentations and a few other cleanups. Thanks for merging!

@Zulko
Copy link
Owner

Zulko commented Oct 10, 2014

I was not saying your changes are unimportant, I was saying I merged the code of several people and you should pull the new code to see if it works. the unimportant was for "still fully back-compatible".

But yeah PEP8 commits atr a little annoying on my side because when there is a git merge conflict I need to correct every PEP8 correction by hand !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants