Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ffmpeg download when importing moviepy.editor #731

Merged
merged 4 commits into from
Apr 16, 2018

Conversation

tburrows13
Copy link
Collaborator

See discussion in #493. Calling imagio.plugins.ffmpeg.downlad() doesn't install ffmpeg if it is already installed somewhere on the system.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 61.807% when pulling 718879b on tburrows13:ffmpegdownload into 6b0710e on Zulko:master.

@coveralls
Copy link

coveralls commented Feb 28, 2018

Coverage Status

Coverage increased (+0.2%) to 61.997% when pulling 27f6485 on tburrows13:ffmpegdownload into 6b0710e on Zulko:master.

@tburrows13 tburrows13 added the bug-fix For PRs and issues solving bugs. label Feb 28, 2018
@tburrows13 tburrows13 requested a review from Zulko March 15, 2018 07:45
@tburrows13 tburrows13 mentioned this pull request Mar 15, 2018
4 tasks
@Zulko
Copy link
Owner

Zulko commented Mar 17, 2018

Definitely necessary, but would this cause a problem for people running moviepy without direct internet access ? Such users would certainly have their own FFMPEG_BINARY, so maybe add something like this:

if os.getenv('FFMPEG_BINARY', 'ffmpeg-imageio') == 'ffmpeg-imageio':
    imageio.plugins.ffmpeg.download()

@mgaitan
Copy link
Collaborator

mgaitan commented Apr 16, 2018

could we merge this?

@tburrows13
Copy link
Collaborator Author

Yep thanks for the reminder.

@tburrows13 tburrows13 merged commit b8fcf45 into Zulko:master Apr 16, 2018
@tburrows13 tburrows13 mentioned this pull request May 22, 2018
@tburrows13 tburrows13 deleted the ffmpegdownload branch March 17, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix For PRs and issues solving bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants