Change verbose_print
#485
Closed
Change verbose_print
#485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see why we need the fancy `sys.stout` when `print` prints to `stout` by default, and flushes automatically. This also means we can use `verbose_print` just like `print` except with the `verbose` parameter before anything to be printed. e.g. `verbose_print(True, var1, var2) which would have failed with the old `verbose_print`. I tried to use `verbose_print` in my application, but acted very weirdly, hence the change.
added 2 commits
March 12, 2017 15:59
|
I should have documented this one, but basically the issue was that in some consoles (and in the IPython notebook, at least at the time), "print" commands get delayed, while stdout.flush are instantaneous, so my method was better at providing feedback. I would be against changing it to print unless it solves some known issues. |
|
I posted this as a question on Stack Overflow here: http://stackoverflow.com/questions/42752218/does-print-delay-in-some-consoles-where-stdout-flush-doesnt |
|
@Gloin1313 do you think you can add @Zulko 's comment in the source code so that if someone tries to change this (like you did), we have an explanation of why it needs to stay as is? Thanks! |
|
Yep, will do! |
Merged
|
Done in #514 |
ghost
pushed a commit
that referenced
this pull request
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see why we need the fancy
sys.stoutwhenprintprints tostoutby default, and flushes automatically. This also means we can useverbose_printjust likeprintexcept with theverboseparameter before anything to be printed. e.g.verbose_print(True, var1, var2) which would have failed with the oldverbose_print`.I tried to use
verbose_printin my application, but acted very weirdly, hence the change.