Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass 't' argument of 'clip.show' as 'HH:MM:SS' format #1594

Merged
merged 2 commits into from
May 27, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented May 27, 2021

  • t argument of clip.show method accepts HH:MM:SS time formats.
  • Add test for internal tool and proper documentation to preview methods.
  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it

@mondeja mondeja added documentation Related to documentation in official project docs or individual docstrings. tests Related to individual tests in the test suite or running the test suite. labels May 27, 2021
@coveralls
Copy link

coveralls commented May 27, 2021

Coverage Status

Coverage increased (+0.3%) to 77.928% when pulling 1da8466 on mondeja:show-t-string into 4d59f79 on Zulko:master.

@mondeja mondeja merged commit b82c9d6 into Zulko:master May 27, 2021
@mondeja mondeja deleted the show-t-string branch May 27, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation in official project docs or individual docstrings. tests Related to individual tests in the test suite or running the test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants