Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply and ensure Black formatting #1101

Merged
merged 7 commits into from
Mar 24, 2020
Merged

Apply and ensure Black formatting #1101

merged 7 commits into from
Mar 24, 2020

Conversation

mgaitan
Copy link
Collaborator

@mgaitan mgaitan commented Mar 17, 2020

Fix for #1097

@coveralls
Copy link

coveralls commented Mar 17, 2020

Coverage Status

Coverage decreased (-0.008%) to 64.409% when pulling 1c80f2b on mgaitan:black into 6d8db84 on Zulko:v2.

@tburrows13
Copy link
Collaborator

So am I correct in saying that this doesn't actually auto-format the code, it just marks PRs as unsuccessful (and therefore unmergable) if they fail?

@mgaitan
Copy link
Collaborator Author

mgaitan commented Mar 17, 2020

@tburrows13 yes, you are right.

@mgaitan
Copy link
Collaborator Author

mgaitan commented Mar 17, 2020

well, I don't know why the git action didn't run. It was automatic when I tried this on my fork.
It seems related to this bug https://github.community/t5/GitHub-Actions/Github-Workflow-not-running-from-pull-request-from-forked/td-p/32979.

Anyway, should be ok after merge.

@mgaitan
Copy link
Collaborator Author

mgaitan commented Mar 17, 2020

And I'm wondering if wouldn't be better to implement #1081 first, removing old python version from the CI matrixes, and apply this targeting directly py36. So, we don't need another PR to apply a new black rewrite.

@tburrows13
Copy link
Collaborator

tburrows13 commented Mar 17, 2020

I agree, I intend to start a new branch today for v2.0 that removes all py27 testing. Then we can merge PRs like this one into it.

@tburrows13 tburrows13 changed the base branch from master to v2 March 20, 2020 12:35
@tburrows13
Copy link
Collaborator

A bit later than expected, I've created #1103. When #1103 is merged into the v2 branch, you can update this PR with a fresh run of Black (without worrying about Py2.7, and then we can merge this in before anything else is merged).

I think adding something into the 'Standard workflow' in Contributing.md would be helpful as well.

Also I think the name 'sanity checks' is not very descriptive. How about 'Code Format Check' or something like that?

@tburrows13 tburrows13 added project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. labels Mar 20, 2020
@tburrows13 tburrows13 added this to the Release v2.0.0 milestone Mar 20, 2020
@mgaitan
Copy link
Collaborator Author

mgaitan commented Mar 24, 2020

@tburrows13 update done.

@tburrows13
Copy link
Collaborator

Thanks for this. I'm happy to merge now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project-admin Anything to do with the administration & organisation of moviepy. I.e. project "meta". refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants