image corruption when concatenating images of different sizes

[mattvenn]

If I have a portrait and a landscape image and try to make them into ImageClips and then concatenate them I get a corrupt frame for the second image.]

fps = 2
clips_with_text = []
files = [
  { 'type': 'img', 'p': 'IMG_20180215_115620141.jpg', 'd': dur_time, 't': "landscape" },                                                                                                                                      
  { 'type': 'img', 'p': 'IMG_20180215_115751222.jpg', 'd': dur_time, 't': "portrait" },     
]

for file in files:              
    video = ImageClip('./media/' + clip['p'], duration=clip['d']).set_fps(fps)
    txt_clip = TextClip(clip['t'], fontsize=140, color='white', bg_color='black', font='Liberation-Sans-Bold').set_position(("center", "bottom")).set_duration(video.duration)                                                                        
                                                                                                                                                                                                                                                          
    result = CompositeVideoClip([video, txt_clip]) # Overlay text on video                                                                                                                                                                            
                                                                                                                                                                                                                                                          
    clips_with_text.append(result)

final_clip = concatenate_videoclips(clips_with_text)
final_clip.write_videofile("final.mp4")

[tburrows13]

Try calling concatenate_videoclips with method=compose. That should centre the smaller videos with a black background. Alternatively, resize all the videos to the same size.

[mattvenn]

Thanks, that stops the corruption.

[mattvenn]

I'm not sure it should be closed though, I think there is a bug. If there are a set of video clips the same size and a set of images the same size it works as expected. With one image a different size, then it gets corrupted only on that image.

[intoro]

Thanks!

…

On Fri, Feb 16, 2018 at 12:35 AM, matt venn ***@***.***> wrote: I'm not sure it should be closed though, I think there is a bug. If there are a set of video clips the same size and a set of images the same size it works as expected. With one image a different size, then it gets corrupted only on that image. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#725 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXntFpuaD-Lt1GJb1E_KUcJglQD0UHSGks5tVT3DgaJpZM4SHFNL> .

[tburrows13]

No, I think it is the expected behaviour. Maybe it should be better documented though, as it’s a very common issue. We could also raise a warning if it happens.

[Jeffiano]

concatenate(clip_list,method="compose") works for me , Thanks !!!