Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SerializationTests on Linux and macOS #247

Merged
merged 1 commit into from
May 31, 2024

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented May 28, 2024

It would fail with System.IO.DirectoryNotFoundException

Could not find a part of the path '[…]/FusionCache/tests/ZiggyCreatures.FusionCache.Tests/bin/Debug/net8.0/Samples\'.

It would fail with `System.IO.DirectoryNotFoundException`
> Could not find a part of the path '[…]/FusionCache/tests/ZiggyCreatures.FusionCache.Tests/bin/Debug/net8.0/Samples\'.
@jodydonetti jodydonetti self-assigned this May 28, 2024
@jodydonetti jodydonetti added the bug Something isn't working label May 28, 2024
@jodydonetti jodydonetti added this to the v1.2.0 milestone May 28, 2024
Copy link
Collaborator

@jodydonetti jodydonetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What!? Did I really write those backslashes? Was I drunk 😅 ?
Thanks for spotting it!

@jodydonetti
Copy link
Collaborator

Just FYI, the build fail is not an issue, I have some cleanup up to do and no time to do it, but it's fine probably.
Will check better asap.

@jodydonetti jodydonetti merged commit ab51d4b into ZiggyCreatures:main May 31, 2024
1 check failed
@0xced 0xced deleted the SerializationTests branch May 31, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants