Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): modify shutdown used in stop() #8863

Merged
merged 5 commits into from
Sep 18, 2024
Merged

fix(rpc): modify shutdown used in stop() #8863

merged 5 commits into from
Sep 18, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

The std::process::exit I introduced for the stop RPC method is not a good idea for the rpc testing because (among other issues) it terminates immediately and the tests require for the method to return before actually finishing with the current process.

Additionally this is a more graceful shutdown and will close #8850

Solution

Terminate the process by sending a SIGINT signal.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage added C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces P-Medium ⚡ labels Sep 11, 2024
@oxarbitrage oxarbitrage requested a review from a team as a code owner September 11, 2024 20:07
@oxarbitrage oxarbitrage requested review from arya2 and removed request for a team September 11, 2024 20:07
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

mergify bot added a commit that referenced this pull request Sep 18, 2024
@mergify mergify bot merged commit c5d8eb5 into main Sep 18, 2024
135 checks passed
@mergify mergify bot deleted the issue8850 branch September 18, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change(rpc): Use graceful termination in stop RPC
2 participants