Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(release): Reduce the end of support time from 20 weeks to 16 weeks #8530

Merged
merged 4 commits into from
May 15, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented May 14, 2024

Motivation

We want Zebra to have the same end of support timeline as zcashd.

Closes #8521.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

Reduces EOS_PANIC_AFTER from 140 to 112

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@arya2 arya2 added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-release Area: Zebra releases and release management P-Medium ⚡ labels May 14, 2024
@arya2 arya2 self-assigned this May 14, 2024
@arya2 arya2 requested a review from a team as a code owner May 14, 2024 21:30
@arya2 arya2 requested review from oxarbitrage and removed request for a team May 14, 2024 21:30
mergify bot added a commit that referenced this pull request May 14, 2024
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arya2 arya2 requested a review from a team as a code owner May 14, 2024 22:30
@arya2 arya2 requested review from upbqdn and removed request for a team May 14, 2024 22:30
@oxarbitrage
Copy link
Contributor

should we put this change in the top of the changelog for the next release now ?

oxarbitrage
oxarbitrage previously approved these changes May 15, 2024
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i think it will be good to explain a bit more the change but i am ok as it is.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@arya2
Copy link
Contributor Author

arya2 commented May 15, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented May 15, 2024

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 0f5450f into main May 15, 2024
191 checks passed
@mergify mergify bot deleted the increase-eos branch May 15, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-release Area: Zebra releases and release management C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert EOS halt period to 16 weeks
2 participants