-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(grpc): Add snapshots #8277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you for adding these snapshots.
I left a few suggestions that may involve significant changes, let me know if you'd like me to open a suggestion PR for some of them.
Feel free to push commits directly or open a PR pointing here. I will go over the suggestions otherwise tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arya2 thank you for the simplifications. looks cleaner now, i made a few small doc changes. feel free to merge.
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
* add grpc snapshot tests * replaces ScanService with MockService in snapshot tests * removes dev-dep in zebra-grpc on zebra-scan and updates snapshots * Apply suggestions from code review Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com> --------- Co-authored-by: Arya <aryasolhi@gmail.com>
Motivation
As part of #8244 we want to do snapshot tests for the responses of the new grpc methods.
PR Author Checklist
Check before marking the PR as ready for review:
Solution
Add snapshots for the grpc methods that currently return other data than
Empty
.Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work