fix(net): Fix off-by-one error in DNS seed peer retries, and clarify logs #6460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra's DNS seed peer retries aren't documented or named correctly: the number of DNS attempts implied by the name doesn't match the implementation.
Closes #6393
Complex Code or Requirements
This is concurrent async code, but this PR doesn't change the number of retries.
Solution
Review
This is a routine audit fix.
Reviewer Checklist