Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log): Add a config for writing logs to a file #6449

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

teor2345
Copy link
Collaborator

@teor2345 teor2345 commented Apr 2, 2023

Motivation

Zebra can't currently write logs to a file - it requires extra shell redirections or a service harness.

This might be confusing for some users.

Solution

  • Add a config with a file path for logging
  • If configured, append logs to that file

Review

This is a low-priority extra Zebra feature.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added P-Low ❄️ I-usability Zebra is hard to understand or use A-diagnostics Area: Diagnosing issues or monitoring performance C-feature Category: New features labels Apr 2, 2023
@teor2345 teor2345 self-assigned this Apr 2, 2023
@teor2345 teor2345 requested a review from a team as a code owner April 2, 2023 23:47
@teor2345 teor2345 requested review from arya2 and removed request for a team April 2, 2023 23:47
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #6449 (e3088ef) into main (5db2243) will decrease coverage by 0.07%.
The diff coverage is 62.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6449      +/-   ##
==========================================
- Coverage   77.78%   77.72%   -0.07%     
==========================================
  Files         304      304              
  Lines       39637    39640       +3     
==========================================
- Hits        30833    30811      -22     
- Misses       8804     8829      +25     

Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

mergify bot added a commit that referenced this pull request Apr 3, 2023
@mergify mergify bot merged commit a049e20 into main Apr 3, 2023
@mergify mergify bot deleted the logs-to-file branch April 3, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance C-feature Category: New features I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants