Linux build improvements #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al override if present. If GBDK_HOME is not set, and the OS is not windows, then ENV binaries are being used and a .exe extension is required for WINE. It seems an explicit path is also required by WINE, so add that since it is known.
…oducing a line at the start of it with -e \n which resulted in the following error: ?ASlink-Warning-Cannot open library module ../Release/zgb/-e .rel If the -e was removed it still errored with ?ASlink-Warning-Cannot open library module ../Release/zgb/ .rel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple changes for MakefileCommon to work better by default on Linux (it doesn't "out of the box" right now). No worries if you don't want to merge them. :)
These * have not * been tested on Windows yet since my Win VM needs a little work at the moment, so testing them would be a good idea.
Only set GBDK_HOME if not already set, allows for local override if present.
If GBDK_HOME is not set, and the OS is not windows, then ENV binaries are being used and a .exe extension is required for WINE. It seems an explicit path is also required by WINE, so this adds that since it is known.
Fix zgb.lib creation for Linux. The current method was producing a line at the start of it with
-e \nwhich resulted in the following error:?ASlink-Warning-Cannot open library module ../Release/zgb/-e .relIf the -e was removed it still errored with
?ASlink-Warning-Cannot open library module ../Release/zgb/ .rel