Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "For many linux build, use aarch64 instead of arm64" #7148

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

NikolajBjorner
Copy link
Contributor

Reverts #7147

aarch64 directive isn't supported for the python build.
One of the following options may resolve this:

  • add AARCH64 directives explicitly for LInux to scripts/mk_util.py.
  • There is not much specific for ARM64+linux at this point. Perhaps passing in ARM64 would do, but then the wheel would also work if you renamed it from arm64 to aarch64 (this would be a simpler solution).
  • use the cmake build system instead of the python (legacy) for the unix distribution. It is rehearsed in some situations, but getting the final bits and pieces right has taken me several iterations before. Experimenting with a self-contained action/pipeline for this may be easier so the pipeline/action can be tested without requiring to run Nightly.yaml, which is not generally triggered.

@NikolajBjorner NikolajBjorner merged commit 1068708 into master Mar 5, 2024
8 of 19 checks passed
@NikolajBjorner NikolajBjorner deleted the revert-7147-smoy/handle-aarch64 branch June 24, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant