Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditionally depend on importlib_resources #7116

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

cj81499
Copy link
Contributor

@cj81499 cj81499 commented Feb 8, 2024

In Python >= 3.9, importlib.resources is available as part of the stdlib.

This change makes it so that the backport is only installed for Python versions where it is actually needed and used.

Relevant docs: https://packaging.python.org/en/latest/specifications/dependency-specifiers/#environment-markers

Originally noticed here: cj81499/advent-of-code#330 (comment)

In python >= 3.9, it's available as part of the stdlib.
@cj81499 cj81499 marked this pull request as ready for review February 8, 2024 07:28
@NikolajBjorner NikolajBjorner merged commit 199ef30 into Z3Prover:master Feb 18, 2024
12 checks passed
@cj81499
Copy link
Contributor Author

cj81499 commented Feb 19, 2024

@NikolajBjorner thanks for merging! :)

Any idea when this will be released?

Thanks again!

NikolajBjorner pushed a commit that referenced this pull request Feb 21, 2024
In python >= 3.9, it's available as part of the stdlib.
@cj81499 cj81499 deleted the patch-1 branch March 4, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants