Use noexcept more.
#7058
Merged
Use noexcept more.
#7058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunoplopes
reviewed
Dec 14, 2023
nunoplopes
reviewed
Dec 15, 2023
nunoplopes
reviewed
Dec 15, 2023
nunoplopes
reviewed
Dec 15, 2023
| @@ -45,7 +45,7 @@ class f2n { | |||
| m_manager.set(m_one, ebits, sbits, 1); | |||
| } | |||
|
|
|||
| f2n(f2n && other) : m_manager(other.m_manager), m_mode(other.m_mode), m_ebits(other.m_ebits), m_sbits(other.m_sbits), | |||
| f2n(f2n && other) noexcept : m_manager(other.m_manager), m_mode(other.m_mode), m_ebits(other.m_ebits), m_sbits(other.m_sbits), | |||
There was a problem hiding this comment.
When this one goes away, there's a build error on Ubuntu in CI. I've added it back for now.
|
FWIW, in the long run these swaps should go. They are reminiscent of pre-C++11 code. We now have std::move, so most of these swaps are useless. |
This applies it to swap functions as well as move constructors, move assignment, etc.
waywardmonkeys
force-pushed
the
more-noexcept
branch
from
6c6fddd
to
e978364
Compare
|
Updated, rebased to fix a merge conflict, and force pushed. |
This removes them for case/body expansion. Suggested by @nunoplopes.
waywardmonkeys
force-pushed
the
more-noexcept
branch
from
e978364
to
7d7624f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies it to swap functions as well as move constructors, move assignment, etc.