Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable Python compilation cache during build" #7054

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

NikolajBjorner
Copy link
Contributor

Reverts #7052

Nightly: manylinux build:

Traceback (most recent call last):
File "scripts/mk_make.py", line 18, in
mk_bindings(API_files)
File "/__w/1/s/scripts/mk_util.py", line 3073, in mk_bindings
cp_z3py_to_build()
File "/__w/1/s/scripts/mk_util.py", line 3001, in cp_z3py_to_build
pycache_prefix_before = sys.pycache_prefix
AttributeError: module 'sys' has no attribute 'pycache_prefix'

@NikolajBjorner NikolajBjorner merged commit f7d9a5b into master Dec 14, 2023
10 of 24 checks passed
@NikolajBjorner
Copy link
Contributor Author

This is the pipeline that fails:

  • job: ManyLinuxBuild
    variables:
    python: "/opt/python/cp37-cp37m/bin/python"
    name: ManyLinux
    displayName: "ManyLinux build"
    pool:
    vmImage: "ubuntu-latest"
    container: "quay.io/pypa/manylinux2014_x86_64:latest"
    steps:
    • script: $(python) scripts/mk_unix_dist.py --nodotnet --nojava
    • script: git clone https://github.com/z3prover/z3test z3test
    • script: $(python) z3test/scripts/test_benchmarks.py build-dist/z3 z3test/regressions/smt2
    • script: cp dist/*.zip $(Build.ArtifactStagingDirectory)/
    • task: PublishPipelineArtifact@0
      inputs:
      artifactName: '$(name)Build'
      targetPath: $(Build.ArtifactStagingDirectory)

Are there updates to it (python3 vs python2?) that apply?
An unrelated update to python scripts led to a regression for pypi installations in the latest release.
A fix is being triaged (or I guess it works given recent feedback on unrelated pypi issues for Mac x64).
The takeaway is it created some disruption downstream.

@wintersteiger
Copy link
Contributor

Oh, yes, this needs a fix for older Pythons.

@NikolajBjorner NikolajBjorner deleted the revert-7052-cwinter_pycache_disable branch June 24, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants