Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Require cmake 3.16 or later. #7015

Merged

Conversation

waywardmonkeys
Copy link
Contributor

Support for requiring cmake < 3.4 may go away soon (according to a deprecation notice when building).

Ubuntu 20.04 provides cmake 3.16 and current is 3.27, so that seems like a reasonable version to require.

Support for requiring cmake < 3.4 may go away soon (according to
a deprecation notice when building).

Ubuntu 20.04 provides cmake 3.16 and current is 3.27, so that seems
like a reasonable version to require.
@waywardmonkeys
Copy link
Contributor Author

I need this for another change that will requires cmake 3.12 or later, but wanted to introduce this separately to ensure no issues with it.

@aytey
Copy link
Contributor

aytey commented Nov 25, 2023

Can I suggest 3.12 rather than 3.16 then? It seems like this would exclude some users “pointlessly” if you only need 3.12 features.

@waywardmonkeys
Copy link
Contributor Author

Well, I don’t think this is actually tested, so not really sure that it even works on any given version. Is there someone that is actually stuck on something as old as 3.12?

@waywardmonkeys
Copy link
Contributor Author

FWIW, 3.12 was released in July 2018 and 3.16 in November 2020.

Along similar lines, Z3 requires C++17 and suggests or needs at least Visual Studio 2019 on Windows.

@NikolajBjorner NikolajBjorner merged commit 9d3fef3 into Z3Prover:master Nov 26, 2023
20 checks passed
@NikolajBjorner
Copy link
Contributor

The way I see it: It is a non-goal for z3 builds to be compatible with stale software pipelines, so 3.16 (instead of 3.12) makes better sense. Downlevel compatibility is a well-known ask for users not upgrading their pipelines, but it is a trap when it comes to flexiblity.

@waywardmonkeys waywardmonkeys deleted the update-baseline-cmake branch November 27, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants