Qel fixes #6999
Merged
Qel fixes #6999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -405,8 +406,18 @@ class mbproj::impl { | |||
| return true; | |||
| } | |||
|
|
|||
| bool has_unsupported_th(const expr_ref_vector fmls) { | |||
There was a problem hiding this comment.
shouldn't you use allow-lists of supported theories instead of blocked lists of unsupported theories? Someone will then start fuzzing this using the special relations theory or user-propagator operators?
NikolajBjorner
added a commit
that referenced
this pull request
Nov 17, 2023
The code is making some assumptions that arrays are 1-dimensional. This is not generally true. Introducing pattern matching to ensure the assumption is met. Avoid get_arg(..) especially when there is an approach based on pattern matching recognizers.
|
On closer inspection there appear to be further systematic issues. Arrays are not necessarily 1-dimensional but the code made some unchecked assumptions. I have updated the code some places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.