Skip to content

Commit

Permalink
fix regression from Grobner port
Browse files Browse the repository at this point in the history
- scan_for_linear returns true if it finds a new linear equation. It then should break GB.
- if scan_for_linear returns false, it should still allow try_modify_eqs.
This behavior was masked by requiring scan_for_linear to always be true before
allowing try_to_modify_eqs.

based on repro from Guido Martinez @mtzguido
  • Loading branch information
NikolajBjorner committed Apr 5, 2023
1 parent 479f844 commit f8242c5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/smt/theory_arith_nl.h
Original file line number Diff line number Diff line change
Expand Up @@ -2264,8 +2264,10 @@ typename theory_arith<Ext>::gb_result theory_arith<Ext>::compute_grobner(svector
return GB_FAIL;
if (get_gb_eqs_and_look_for_conflict(eqs, gb))
return GB_PROGRESS;
if (scan_for_linear(eqs, gb))
return GB_NEW_EQ;
}
while(scan_for_linear(eqs, gb) && m_params.m_nl_arith_gb_perturbate &&
while(m_params.m_nl_arith_gb_perturbate &&
(!m_nl_gb_exhausted) && try_to_modify_eqs(eqs, gb, next_weight));
return GB_FAIL;
}
Expand Down

0 comments on commit f8242c5

Please sign in to comment.