fix model reconstruction ordering for elim_unconstrained

Z3Prover · Jan 9, 2023 · 64ec8ac · 64ec8ac
1 parent 30e0f78
commit 64ec8ac
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/ast/simplifiers/elim_unconstrained.cpp b/src/ast/simplifiers/elim_unconstrained.cpp
@@ -357,14 +357,16 @@ void elim_unconstrained::update_model_trail(generic_model_converter& mc, vector<
             trail.hide(entry.m_f);
             break;
         case generic_model_converter::instruction::ADD:
+            // trail.push(entry.m_f, entry.m_def, nullptr, old_fmls);
             break;
         }
     }
     scoped_ptr<expr_replacer> rp = mk_default_expr_replacer(m, false);
     scoped_ptr<expr_substitution> sub = alloc(expr_substitution, m, true, false);
     rp->set_substitution(sub.get());
     expr_ref new_def(m);
-    for (auto const& entry : mc.entries()) {
+    for (unsigned i = mc.entries().size(); i-- > 0; ) {
+        auto const& entry = mc.entries()[i];
         switch (entry.m_instruction) {
         case generic_model_converter::instruction::HIDE:
             break;